feat(core): Default span status to ok in transaction mode - #22521
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
andreiborza
reviewed
Jul 23, 2026
| @@ -78,7 +78,7 @@ function _startSpan<T>(options: OpenTelemetrySpanContext, callback: (span: Span) | |||
| () => callback(span), | |||
| () => { | |||
| // Only set the span status to ERROR when there wasn't any status set before, in order to avoid stomping useful span statuses | |||
Member
There was a problem hiding this comment.
l: The comment is now outdated.
| @@ -95,7 +95,7 @@ function _startSpan<T>(options: OpenTelemetrySpanContext, callback: (span: Span) | |||
| () => callback(span), | |||
| () => { | |||
| // Only set the span status to ERROR when there wasn't any status set before, in order to avoid stomping useful span statuses | |||
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit fe81e33. Configure here.
mydea
force-pushed
the
fn/span-status-default
branch
from
July 23, 2026 08:27
fe81e33 to
a360faa
Compare
mydea
marked this pull request as ready for review
July 23, 2026 12:11
mydea
requested review from
andreiborza,
chargome,
isaacs,
logaretm,
msonnb and
nicohrubec
and removed request for
a team
July 23, 2026 12:11
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We do this in node via opentelemetry span processing today, so if we remove this processing a bunch of tests fail for node which rely on span status being OK. I figured this makes sense and likely is more or less the same if this is ok or unset for a span, and also aligns with span streaming 🤔